Autofill engagement KPIs for pixel reporting #2806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the password management UI
github-actions
bot
added
the
bot: not in app board
6 tasks
amddg44
removed
the
bot: not in app board
aataraxiaa
approved these changes
May 23, 2024
…kpis # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/Application/AppDelegate.swift
amddg44
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
May 23, 2024
Task/Issue URL: https://app.asana.com/0/72649045549333/1207357107981852/f iOS PR: duckduckgo/iOS#2885 macOS PR: duckduckgo/macos-browser#2806 What kind of version bump will this require?: Minor Description: Autofill engagement KPIs for pixel reporting
…kpis # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/Autofill/ContentOverlayViewController.swift # DuckDuckGo/SecureVault/View/SaveCredentialsViewController.swift # DuckDuckGo/Statistics/GeneralPixel.swift
samsymons
added a commit
that referenced
this pull request
May 23, 2024
# By Fernando Bunn (3) and others # Via GitHub * main: Autofill engagement KPIs for pixel reporting (#2806) autofill: don't prefix autofill email pixels with `m.mac.` (#2808) Bump BSK (#2807) Make profile selector optional (#2811) Add History to iOS (updated UI and rollout) (#2770) New autofill save & update password prompt pixels for alignment with iOS (#2801) Add mylife data broker (#2786) Increase test timeout (#2810) Subscription refactoring, BSK update (#2809) Check for entitlement in DBP agent (#2802) move permanent survey card to first position (#2804) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj
samsymons
added a commit
that referenced
this pull request
May 24, 2024
# By Elle Sullivan (8) and others # Via Elle Sullivan (3) and GitHub (2) * main: (26 commits) Autofill engagement KPIs for pixel reporting (#2806) autofill: don't prefix autofill email pixels with `m.mac.` (#2808) Bump BSK (#2807) Make profile selector optional (#2811) Add History to iOS (updated UI and rollout) (#2770) New autofill save & update password prompt pixels for alignment with iOS (#2801) Add mylife data broker (#2786) Increase test timeout (#2810) Subscription refactoring, BSK update (#2809) Check for entitlement in DBP agent (#2802) move permanent survey card to first position (#2804) Subscription refactoring (#2764) Bump version to 1.89.0 (191) Merge pir stabilization feature branch into main (#2789) Update age params for multiple brokers (#2800) Fix top level navigation blocks (#2792) Adding to the Dock automatically (#2722) Fix lint error Make activity only call completion once all work has actually finished Fix activity scheduler not calling completion ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
May 30, 2024
* main: (33 commits) Remove autofill survey (#2819) Bump version to 1.90.0 (192) Set marketing version to 1.90.0 Update embedded files Privacy Pro survey support (#2816) Update PeopleWhiz Broker Files to use hash id (#2814) Update BSK due to iOS changes. (#2776) Scroll address bar to caret when using arrows (#2799) Privacy Pro macOS quick follow ups (#2813) BSK bump for iOS RMF updates (#2798) Autofill engagement KPIs for pixel reporting (#2806) autofill: don't prefix autofill email pixels with `m.mac.` (#2808) Bump BSK (#2807) Make profile selector optional (#2811) Add History to iOS (updated UI and rollout) (#2770) New autofill save & update password prompt pixels for alignment with iOS (#2801) Add mylife data broker (#2786) Increase test timeout (#2810) Subscription refactoring, BSK update (#2809) Check for entitlement in DBP agent (#2802) ...
samsymons
added a commit
that referenced
this pull request
Jun 1, 2024
# By Elle Sullivan (10) and others # Via GitHub (6) and others * main: (42 commits) Update autoconsent to v10.9.0 (#2822) Bump version to 1.90.0 (196) Revert "Add PIPAgent entitlement (#2821)" (#2823) Bump version to 1.90.0 (195) Bump version to 1.90.0 (194) Add PIPAgent entitlement (#2821) Fixes some VPN uninstallation issues (#2820) Bump version to 1.90.0 (193) Remove autofill survey (#2819) Remove autofill survey (#2819) Bump version to 1.90.0 (192) Set marketing version to 1.90.0 Update embedded files Privacy Pro survey support (#2816) Update PeopleWhiz Broker Files to use hash id (#2814) Update BSK due to iOS changes. (#2776) Scroll address bar to caret when using arrows (#2799) Privacy Pro macOS quick follow ups (#2813) BSK bump for iOS RMF updates (#2798) Autofill engagement KPIs for pixel reporting (#2806) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/72649045549333/1207357107981852/f
Tech Design URL:
CC:
Description:
New Autofill engagement KPI pixels
Steps to test this PR:
Disable Sync (if enabled) and reset Autofill data via debug menu. Also Change the Activation Date to Less than 5 days ago (or today)
Use
autofillas a filter for XCode console logsGo to https://fill.dev/form/login-simple, enter credentials and save when prompted
Confirm pixel
m.autofill.onboardeduseris fired (and that the messageAutofill save event firedlogs)Go back to https://fill.dev/form/login-simple and fill using the saved credentials
Confirm the message
Autofill fill event firedis loggedPerform a search
Confirm these 3 pixels are fired (where the bucket names corresponds to the number of accounts and credit cards saved):
m.autofill.activeuser,m_mac_autofill_logins_stacked ["pixelSource": "browser-dmg", "appVersion": "1.88.0", "count_bucket": "few"],m_mac_autofill_creditcards_stacked ["pixelSource": "browser-dmg", "appVersion": "1.88.0", "count_bucket": "none"]Visit https://fill.dev/form/registration-email (sign into Email Protection if not already signed in)
Select primary duck address
Confirm the message
Autofill fill event firedis logged (it will probably fire twice as the JS layer fires 2 pixels - email fill and identity fill)Select private duck address
Confirm both
Autofill fill event firedandAutofill save event firedmessages are logged (again, there will be 2 fill events, but only 1 save)Choose a generated password
Confirm just
Autofill fill event firedis logged (since the login is already autosaved due to choosing a private duck address)Click
Registerand then come back to the registration form screenThis time choose a generated password first and confirm both
Autofill fill event firedandAutofill save event firedmessages are loggedGo to the Passwords screen and manually create a new entry
Confirm the message
Autofill save event firedis loggedSave a credit card and an identity in the form
Visit https://fill.dev/form/credit-card-simple and choose the saved credit card to fill the form
Confirm the message
Autofill fill event firedis loggedVisit https://fill.dev/form/identity-simple and choose the saved idenity to fill the form
Confirm the message
Autofill fill event firedis logged"Reset Autofill Data" via Debug Autofill screen
Import password data (at least 10 entries - can use this DuckDuckGo Passwords Test.csv)
Confirm the pixel
m_mac_autofill_onboardeduseris fired (and that the messageAutofill save event firedlogs)Perform a search in browser
Confirm the pixel
m.autofill.enableduseris firedOn the iOS build, confirm there is at least 1 different password saved
Enable sync and connect to the iOS build
Confirm the message
Autofill save event firedis logged when new sync data comes inInternal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation